Repository navigation
take aria-hidden from theme and add to dt table itself - #28
tkranenburgrivm wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change that provides screen-reader-only styling independently of the optional theme.
No open issues 🎉
What changed in this PR
Moves screen-reader-only styling from the optional theme into ro_dt_table(), so tables provide it independently of the theme or host Bootstrap version.
Changes:
- Removes the
.visually-hiddenCSS rule from the theme. - Adds the same rule through the table’s JavaScript callback, with an element-ID check to inject it only once per document.
| File | Description |
|---|---|
R/ro_dt_theme.R |
Removes theme-provided screen-reader-only styling. |
R/ro_dt_table.R |
Injects screen-reader-only styling during table initialization. |
Review effort: Balanced
Co-authored-by: tkranenburgrivm <235857189+tkranenburgrivm@users.noreply.github.com>
No longer needed: main already silences missing_package_linter in the vignette (same as the other ROvis repos), so ci.yaml stays identical across the suite. This reverts commit 6a235f0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@tkranenburgrivm I reverted the Copilot commit that added |
No description provided.